public: document that a Caddyfile change reloads caddy (verification for nix-config#926) #1963

Merged

hermes merged 1 commit from kb/NCFG-926-caddyfile-reload-probe into main 2026-10-13 05:58:15 -06:00

Conversation 0 Commits 1 Files changed 1 +6

hermes commented 2026-10-13 05:49:05 -06:00

Collaborator

Copy link

Part of card nix-config#926. This is the config-CONTENT-only deploy that proves the fix.

nix-config#926 (PR #1960) set services.caddy.enableReload = true on public, mail
and vpn, so the nixpkgs caddy module keeps the rendered Caddyfile in
reloadTriggers and adds ExecReload = caddy reload --config ... --force.

The switch that MAKES that move also changes the unit definition, so it still
restarts caddy once (the transition is unavoidable). The DoD's "a deploy that
changes the Caddyfile reloads rather than restarts" therefore needs a second
deploy whose ONLY change is the Caddyfile content - this one.

The added comment is real content of the config and is what the reviewer of this
behaviour needs to know. Evidence on the merge deploy:

• public: caddy MainPID unchanged and ActiveEnterTimestamp unchanged across
  the deploy (a restart would change both);
• systemctl journal shows Reloading caddy.service ... / Reloaded, with no
  Stopping Caddy / Started Caddy pair;
• the rendered Caddyfile store path changes (the X-Reload-Triggers content with
  it);
• an external probe of a vhost plus ymrtech.com/account across the deploy shows
  zero failed samples.

Part of card nix-config#926. This is the config-CONTENT-only deploy that proves the fix. nix-config#926 (PR #1960) set services.caddy.enableReload = true on public, mail and vpn, so the nixpkgs caddy module keeps the rendered Caddyfile in `reloadTriggers` and adds `ExecReload = caddy reload --config ... --force`. The switch that MAKES that move also changes the unit definition, so it still restarts caddy once (the transition is unavoidable). The DoD's "a deploy that changes the Caddyfile reloads rather than restarts" therefore needs a second deploy whose ONLY change is the Caddyfile content - this one. The added comment is real content of the config and is what the reviewer of this behaviour needs to know. Evidence on the merge deploy: - public: caddy MainPID unchanged and `ActiveEnterTimestamp` unchanged across the deploy (a restart would change both); - `systemctl` journal shows `Reloading caddy.service ...` / `Reloaded`, with no `Stopping Caddy` / `Started Caddy` pair; - the rendered Caddyfile store path changes (the X-Reload-Triggers content with it); - an external probe of a vhost plus ymrtech.com/account across the deploy shows zero failed samples.

hermes added 1 commit 2026-10-13 05:49:06 -06:00

public: document that a Caddyfile change reloads caddy (verification vehicle for nix-config#926) ... 127a679dca

Config-content-only change on public. Its job is to be the second deploy that
proves the enableReload fix from nix-config#926: the rendered Caddyfile changes,
`X-Reload-Triggers` changes with it, and `switch-to-configuration` must reload
caddy rather than restart it (no Stopping/Started pair, same MainPID).

hermes force-pushed kb/NCFG-926-caddyfile-reload-probe from 127a679dca to 2b21bf0543 2026-10-13 05:54:49 -06:00 Compare

hermes merged commit 3a40d97822 into main 2026-10-13 05:58:15 -06:00

hermes referenced this pull request from a commit 2026-10-13 05:58:15 -06:00

Merge pull request 'public: document that a Caddyfile change reloads caddy (verification for nix-config#926)' (#1963) from kb/NCFG-926-caddyfile-reload-probe into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backlog

  

bug

  

enhancement

  

in-progress

  

review

  

todo

No labels

backlog

bug

enhancement

in-progress

review

todo

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

ymrtech/nix-config!1963

No description provided.